Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client-go: attach request source with retry info for coprocessor (#46706) #47003

Merged
merged 4 commits into from
Sep 18, 2023
Merged

client-go: attach request source with retry info for coprocessor (#46706) #47003

merged 4 commits into from
Sep 18, 2023

Conversation

you06
Copy link
Contributor

@you06 you06 commented Sep 15, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Cherry pick #46706 to standalone branch.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2023
@tiprow
Copy link

tiprow bot commented Sep 15, 2023

Hi @you06. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@you06 you06 force-pushed the tidb-6.5-retry-info branch from 646768e to 97ae8f5 Compare September 15, 2023 07:51
cfzjywxk
cfzjywxk reviewed Sep 15, 2023
View reviewed changes
store/copr/coprocessor.go
// timeout value for one kv readonly reqeust
tidbKvReadTimeout uint64
// firstReadType is used to indicate the type of first read when retrying.
firstReadType string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When is the firstReadType initialized to a non-empty value for coprocessor tasks?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, and req.ReadType will be initialized by replica selector.

@you06
Copy link
Contributor Author

you06 commented Sep 15, 2023

/retest

@tiprow
Copy link

tiprow bot commented Sep 15, 2023

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 15, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekexium, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-15 08:31:57.054868124 +0000 UTC m=+247083.022456178: ☑️ agreed by zyguan.
  • 2023-09-15 10:44:35.872999319 +0000 UTC m=+255041.840587369: ☑️ agreed by ekexium.

@hawkingrei
Copy link
Member

/test all

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 16, 2023

@hawkingrei: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@tiprow
Copy link

tiprow bot commented Sep 16, 2023

@hawkingrei: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@you06
Copy link
Contributor Author

you06 commented Sep 16, 2023

/retest

@tiprow
Copy link

tiprow bot commented Sep 16, 2023

@you06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@you06
Copy link
Contributor Author

you06 commented Sep 16, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 16, 2023
@you06
Copy link
Contributor Author

you06 commented Sep 16, 2023

/retest

2 similar comments
@cfzjywxk
Copy link
Contributor

/retest

@you06
Copy link
Contributor Author

you06 commented Sep 18, 2023

/retest

@you06 you06 force-pushed the tidb-6.5-retry-info branch from 0ac54c8 to bfcde0f Compare September 18, 2023 03:32
@cfzjywxk cfzjywxk merged commit 3bad737 into pingcap:tidb-6.5-with-kv-timeout-feature Sep 18, 2023
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
@Tema @you06 @ti-chi-bot
client-go: attach request source with retry info for coprocessor (pin…
92cc413 
…gcap#46706) (pingcap#47003) (pingcap#6)

* client-go: attach request source with retry info for coprocessor (pingcap#46509) (pingcap#46706)

close pingcap#46514

* restore bazelversiong

Signed-off-by: you06 <[email protected]>

* remove unused field

Signed-off-by: you06 <[email protected]>

* update client-go

Signed-off-by: you06 <[email protected]>

---------

Signed-off-by: you06 <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>

Signed-off-by: you06 <[email protected]>
Co-authored-by: you06 <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk left review comments

@zyguan zyguan zyguan approved these changes

@ekexium ekexium ekexium approved these changes

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@you06 @hawkingrei @cfzjywxk @zyguan @ekexium @ti-chi-bot